[Apparmor-dev] [RFC 2/5] initscript: support builtin apparmor

[Steve Beattie]

On Wed, Apr 04, 2007 at 02:05:47PM -0700, Seth Arnold wrote:
> Nice cleanups. :)

Thanks.

> > +mount_subdomainfs() {
> > +	# for backwords compatibility
> > +	if grep -q subdomainfs /proc/filesystems && ! grep -q subdomainfs /proc/mounts; then
> > +		if [ -n "${SUBDOMAINFS_MOUNTPOINT}" ]; then
> > +			SFS_MOUNTPOINT=${SUBDOMAINFS_MOUNTPOINT}
> 
> Seems strange that this one function sets SFS_MOUNTPOINT, but
> the other possibility locations for SFS_MOUNTPOINT are set in
> is_apparmor_loaded(). Maybe not worth fixing, but it feels a bit strange.

Agreed, I've ripped out the SFS_MOUNTPOINT assignment from there, and
combined the two if statements into one.

Thanks for the feedback.

-- 
Steve Beattie
SUSE Labs, Novell Inc. 
<sbeattie at suse.de>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://forge.novell.com/pipermail/apparmor-dev/attachments/20070404/75089408/attachment.pgp