[Apparmor-dev] [RFR] patches for profile tools to work with the latest kernel

[jesse michael]

On Fri, Jul 13, 2007 at 01:09:50PM -0600, Dominic Reynolds wrote:
> The patches are to enable the profile development tools work with the most
> recent AppArmor kernel module that will be included in openSUSE 10.3 alpha6
> and corresponds to the version in:

These patches are working well for me with the slight problem that the 
profile loading code has a bug in it that causes it to fail when it 
encounters trailing # comments on lines with rules.

The basic profiles included with 10.3 don't have any of these, but the 
/sbin/dhpcd profile in /etc/apparmor/profiles/extras/ has the following
line which causes logprof to error out when you try to create a new
profile and it scans for existing-but-inactive profiles--

  /etc/init.d/syslog Ux, # fixme

Here's a simple patch to make it strip trailing comments from rules when 
loading profiles.  It'd be nice to preserve these when we encounter them, 
but we currently strip other inline comments also so it might not be that
bad.  Hopefully when we switch over to the parser library that'll be fixed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: strip-trailing-comments.diff
Type: text/x-patch
Size: 3612 bytes
Desc: not available
Url : http://forge.novell.com/pipermail/apparmor-dev/attachments/20070714/481aa2c3/strip-trailing-comments.bin