[Apparmor-dev] Re: repost of network toggle patches for the tools and bug fixes for repo

[jesse michael]

On Fri, Jul 27, 2007 at 01:46:38AM -0700, jesse michael wrote:
> On Tue, Jul 24, 2007 at 06:25:19PM -0700, John Johansen wrote:
> > choosing * doesn't eliminate questions/choices it should (NEW)
> > Directory perm bug
> 
> convert_regexp() is currently broken.  I'm working on fixing this.

Here's a patch that should fix the * and ** conversions done in
convert_regexp().  The reason it's this gross is that the rules for 
how * and ** expand are different when they're the only part of the 
glob at a particular directory level.  

Essentially, when they're used along with a literal part of a path 
element, they can collapse down to nothing, but if they're alone, 
they have to match at least one character.

A few examples should make that more clear--

  /tmp/foo* matches both /tmp/foo and /tmp/foobar
  /tmp/* matches /tmp/foo, but not /tmp/
  /tmp/**/baz matches /tmp/foo/bar/baz, but not /tmp//baz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-convert_regexp.diff
Type: text/x-patch
Size: 2525 bytes
Desc: not available
Url : http://forge.novell.com/pipermail/apparmor-dev/attachments/20070727/c333e8d2/fix-convert_regexp.bin