[Apparmor-dev] Gentoo AppArmor

[Mario Fetka]

Am Tuesday 18 November 2008 18:47:18 schrieb Steve Beattie:
> On Sat, Nov 15, 2008 at 05:25:41PM +0100, Mario Fetka wrote:
> > i am a gentoo user and creating some ebuilds for gentoo
> > ( svn: http://mars.arge.at/svn/linamh/trunk/apparmor/
> > layman: http://ftp.mars.arge.at/pub/Foverlay/geos_one-overlay.xml )
>
> Cool, thanks for doing this!

now the really cool thing starts creating profiles for gentoo !

>
> > Submitted By: Mario Fetka (mario dot fetka at gmail dot com)
> > Date: 2008-11-10
> > Initial Package Version: 2.3.1
> > Origin: me
> > Upstream Status: unkonown
> > Description: fix compile and remove test on build
> >
> > diff -Naur apparmor-parser-2.3.1.orig/Makefile
> > apparmor-parser-2.3.1/Makefile ---
> > apparmor-parser-2.3.1.orig/Makefile	2008-05-26 11:22:56.000000000 +0000
> > +++ apparmor-parser-2.3.1/Makefile	2008-11-09 18:34:02.820003875 +0000 @@
> > -127,7 +127,7 @@
> >
> >  all: 	$(TOOLS) $(MANPAGES) ${HTMLMANPAGES} techdoc.pdf
> > techdoc/index.html $(Q)make -C po all
> > -	$(Q)make -s tests
> > +#	$(Q)make -s tests
>
> Ideally the tests would be light-weight enough that they can be enabled
> on every build. Unfortunately, a very recent commit that was intended
> to help reduce memory usage by the parser causes two of the regression
> stress tests to take a long time (5 min each here), but they do complete.
> I'm hoping to look into it, but in the mean time, you can disable the
> specific tests by adding
>
>   #=DISABLED
>
> to the header in each of parser/tst/simple_tests/vars_stress_01.sd
> and parser/tst/simple_tests/vars_stress_02.sd
> (parser/tst/simple_tests/vars_stress_03.sd is similarly already disabled).
> With those tests disabled, the rest of the unit and parsing tests should
> add very little time to the build process.
>
> >  apparmor_parser: $(OBJECTS) $(PCREOBJECTS) $(AAREOBJECTS)
> >  	rm -f ./libstdc++.a
> > @@ -249,6 +249,9 @@
> >  .PHONY: install-debian
> >  install-debian:
> >
> > +.PHONY: install-unknown
> > +install-unknown:
> > +
>
> This is fine, but an install-gentoo section if needed would be accepted
> as well.

gentoo ebuilds have a special test section that a user can enable with the 
"test" useflag
so tests in build should not be done (yes the test section isn't activated in 
my ebuild's is on the todo list 

>
> > diff -Naur apparmor-parser-2.3.1.orig/rc.apparmor.functions
> > apparmor-parser-2.3.1/rc.apparmor.functions ---
> > apparmor-parser-2.3.1.orig/rc.apparmor.functions	2008-06-09
> > 11:00:28.000000000 +0000 +++
> > apparmor-parser-2.3.1/rc.apparmor.functions	2008-11-10 11:10:57.475004764
> > +0000 @@ -68,7 +68,7 @@
> >  fi
> >
> >  # SUBDOMAIN_DIR and APPARMOR_DIR might be defined in
> > subdomain.conf|apparmor.conf -if [ -d "${APPAMROR_DIR}" ] ; then
> > +if [ -d "${APPARMOR_DIR}" ] ; then
>
> Bah, I thought these typos had been stamped out.
>
> Otherwise, the patch to the parser was fine. I've committed it to
> subversion.

thx 
and keep doing this greate work

Mario