[PATCH] fix off-by-one in src/translatorsfilelistingimporter.cpp
Robby Stephenson
robby at periapsis.org
Thu Oct 5 22:08:55 MDT 2006
On Thursday 05 October 2006 9:02, you wrote:
> https://bugzilla.novell.com/show_bug.cgi?id=207685 shows an off by one
> error in the code that determines the volume label, I assume from a CD.
Thanks very much for the patch.
> I think the volume name code itself is crazy but the attached trivial
> patch solves the lesser problem.
:) I think I copied that code from vobcopy. I just added in a check for
iso9660 and udf file systems, which I know work, so maybe there's a bit
more sanity there now.
> You should consider, if you haven't
> already, using Solid when you do the KDE4 port to get the volume name for
> all types of devices, not just CDs.
Absolutely. I'm looking forward to KDE 4 with great anticipation, Solid
being one of the many reasons.
Robby
More information about the tellico-users
mailing list