Reduced header file inclusions
Jens Seidel
jensseidel at users.sf.net
Wed Apr 11 14:23:43 MDT 2007
On Tue, Apr 10, 2007 at 04:35:36PM +0200, Jens Seidel wrote:
> On Tue, Apr 10, 2007 at 06:56:03AM -0700, Robby Stephenson wrote:
> > Thanks for the patch, Jens.
I checked now most other header files and attached a new patch.
I did not checked src/translators/btparse/ and src/translators/pilotdb/
as these directories are probably from external sources. I wonder
whether you synchronize these with upstream? Do you report bugs (such as
the wrong memory access in the pilotdb exporter)?
Robby, please try to fix the svn log message of the previous patch, you
mispelled my name (Ken instead of Jens).
svn --revprop propedit -r 1741 svn:log
should do it.
> > Did you create it with some sort of tool that
> > checks include files, or just a lot of source file reading? :)
As far as I know there exists not a single free tool to refactor and
check C++ code. I only know splint which is restricted to C. What a shame!
> The inclusion is always (?) required in the following cases:
> class Y : public X # inheritance
> X m_x # variable definition
> Y<X> # used in template parameters?
The last is wrong. It depends on Y whether X needs to be defined. If Y
is e.g. QPtrVector than it's sufficient to provide a declaration.
I'm not sure how both patches affect tellico. But at least in theory
the compile should be faster and include graphs smaller (no need to
rebuild large parts if a header file changed; code parser such as
doxygen will be faster).
Jens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tellico_include.diff.gz
Type: application/octet-stream
Size: 3330 bytes
Desc: not available
Url : http://forge.novell.com/pipermail/tellico-users/attachments/20070411/e3de3d82/tellico_include.diff.obj
More information about the tellico-users
mailing list