make check fails

[Jens Seidel]

On Mon, Mar 19, 2007 at 11:27:47PM -0700, Robby Stephenson wrote:
> On Saturday 17 March 2007, Jens Seidel wrote:
> > I noticed that tellico has an internal test feature in the source code.
> > It still fails:
> >
> > *****************************************************
> > ./formattest
> > formattest:
> > *****************************************************
> > formattest: Title: checking 'Title' against expected 'Title'... ok
> > formattest: Title: checking 'title' against expected 'Title'... KO!
> > make[2]: *** [check] Error 1
> 
> Odd, I don't see that.

Right. The problem is that the tests evaluate the config settings from
~/.kde/share/config/tellicorc, in this case "Auto Capitalization=false".

The conditional
if(Config::autoCapitalization())
in src/field.cpp:217 should not depend on user config settings.

The solution is probably to create a default configuration in the test
code so that no new config object is created.

> > PS: AM_CPPFLAGS= is preferred over INCLUDES= which is deprecated.
> > See autoconf.pdf, page 68.
> 
> How far backwards compatible is it? I don't want to break that just for the 
> heck of it.

I'm very confident that even 10 year old versions of automake support it.
I can create a patch and test it against old versions if you want. It's
a good way to improve my autotool knowlegde (I "autotoolizised" only two
projects up to now). The long term solution is probably a switch to
cmake anyway, as the rest of KDE. I don't have any experience with it.

CMake: http://dot.kde.org/1172083974/

Jens