make check fails

[Robby Stephenson]

On Tuesday 20 March 2007, Jens Seidel wrote:
> Right. The problem is that the tests evaluate the config settings from
> ~/.kde/share/config/tellicorc, in this case "Auto Capitalization=false".
>
> The conditional
> if(Config::autoCapitalization())
> in src/field.cpp:217 should not depend on user config settings.
>
> The solution is probably to create a default configuration in the test
> code so that no new config object is created.

Right, of course. I forgot about that, thanks for pointing it out.

> > > PS: AM_CPPFLAGS= is preferred over INCLUDES= which is deprecated.
> > > See autoconf.pdf, page 68.
> >
> > How far backwards compatible is it? I don't want to break that just for
> > the heck of it.
>
> I'm very confident that even 10 year old versions of automake support it.

After a search, it looks like you're right. They equivalence goes back to at 
least 2003, so there aren't probably any drawbacks. I'll go ahead with the 
changes.

> The long term solution is probably a switch to
> cmake anyway, as the rest of KDE. I don't have any experience with it.

Yeah, along with the port to KDE4, that'll come next.

Robby