External data sources on KDE 4 Tellico (patch)

[Stepan Roh]

Hi.

I am attaching a patch for KDE 4 Tellico (against trunk r3242). It allows data 
sources of type external application to work. Unfortunately if search is 
successful Tellico crashes instantly in 9 out of 10 tries (results show in the 
table and then it says goodbye).

Other glitches I found:
1. search term is passed as second argument of external application (first one 
is empty)
2. gif images are not saved in the .tc file - they are shown, but not saved
3. it crashes a lot :-(
4. progress dialog is shown whenever image is processed (at least logs indicate 
that) - once I had 35 of them opened at once
5. opening another collection leaves table empty and unusable

Well, that's all. Oh, by the way, Tellico is great! :-)

Have a nice day.

Stepan Roh
-------------- next part --------------
Index: src/fetch/execexternalfetcher.cpp
===================================================================
--- src/fetch/execexternalfetcher.cpp	(revision 3263)
+++ src/fetch/execexternalfetcher.cpp	(working copy)
@@ -165,9 +165,10 @@
   m_process = new KProcess();
   connect(m_process, SIGNAL(readyReadStandardOutput()), SLOT(slotData()));
   connect(m_process, SIGNAL(readyReadStandardError()), SLOT(slotError()));
-  connect(m_process, SIGNAL(processExited(int, QProcess::ExitStatus)), SLOT(slotProcessExited()));
+  connect(m_process, SIGNAL(finished(int, QProcess::ExitStatus)), SLOT(slotProcessExited()));
+  m_process->setOutputChannelMode(KProcess::SeparateChannels);
   m_process->setProgram(m_path, args_);
-  if(!m_process->execute()) {
+  if(m_process->execute() < 0) {
     myDebug() << "ExecExternalFetcher::startSearch() - process failed to start" << endl;
     stop();
   }