More serious things with explained patch

[Robby Stephenson]

On Wednesday 04 February 2009, Regis Boudin wrote:
> Hi again,
>
> So, after I sent a nice screenshot, a couple of technical aspects.
>
> Attached is the svn diff I had to apply to build for windows with Visual
> Studio 2008.
> The main issues are :
>  * F_OK is not defined. I suppose what I did is the easiest workaround.
>  * Including ast.c which is already compiled means the same symbols are
>    present twice. Not including it is probably the best fix. BtParse is
>    definitely some ugly piece of code.

Very true...

>  * The compiler doesn't like making ksharedptr templates about classes it
>    doesn't know anything about. Not certain about this one. I had a
> similar issue on Linux when compiling in "final" mode, but couldn't fix
> it.

Yeah, including the h files in there makes it work. It was pain though, when 
I was modifying them because everything that used a vector had to be 
recompiled.

> * the Microsoft compiler doesn't like the DEBUG_BLOCK and MARK 
> macros. No idea why, the error message is not very helpful.

Maybe we put ifdef WINDOWS or something around the contents of the macros?

>  * #warning isn't recognised. Some are meant to disappear. The CDDB one
>    should probably be shown when calling CMake instead.

True

Robby