More serious things with explained patch

[Regis Boudin]

On Thu, February 5, 2009 04:10, Robby Stephenson wrote:
>>  * The compiler doesn't like making ksharedptr templates about classes
>> it
>>    doesn't know anything about. Not certain about this one. I had a
>> similar issue on Linux when compiling in "final" mode, but couldn't fix
>> it.
>
> Yeah, including the h files in there makes it work. It was pain though,
> when
> I was modifying them because everything that used a vector had to be
> recompiled.

Sure. Will keep the change local for now.

>> * the Microsoft compiler doesn't like the DEBUG_BLOCK and MARK
>> macros. No idea why, the error message is not very helpful.
>
> Maybe we put ifdef WINDOWS or something around the contents of the macros?

That's definitely an idea. Either that or checking the compiler, but it's
an implementation detail.

>>  * #warning isn't recognised. Some are meant to disappear. The CDDB one
>>    should probably be shown when calling CMake instead.
>
> True

Will have a look at clearing the CDDB one. Surrounding the #warning's with
#ifdefs might work in the meantime.

Another thing is a couple of flags in src/CMakeList where I force
SKIP_BUILD_RPATH and --as-needed. I set them with debian/rules anyway, so
whether they are set for everyone or not is up to you.

Regis